Add support for uploading attestations in legacy API #15952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodruffw
reviewed
May 13, 2024
woodruffw
reviewed
May 13, 2024
facutuesca
force-pushed
the
upload-attestations
branch
from
af6432f
to
784f446
Compare
woodruffw
reviewed
May 13, 2024
25 tasks
facutuesca
force-pushed
the
upload-attestations
branch
from
784f446
to
e0b9a33
Compare
kairoaraujo
reviewed
May 21, 2024
facutuesca
force-pushed
the
upload-attestations
branch
2 times, most recently
from
9afeac1
to
7214138
Compare
woodruffw
reviewed
Jun 17, 2024
woodruffw
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
LGTM overall, nice work @facutuesca!
Note for other reviewers: this PR intentionally discards the attestations after verifying them, both for an initial testing period and to keep the changeset small. We'll follow up with another PR to persist the attestations 🙂
facutuesca
force-pushed
the
upload-attestations
branch
2 times, most recently
from
45819f3
to
50a69a9
Compare
woodruffw
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
LGTM, thanks @facutuesca!
(Needs another dependency deconflict.)
facutuesca
force-pushed
the
upload-attestations
branch
5 times, most recently
from
b4ba06f
to
6d8a0ab
Compare
facutuesca
force-pushed
the
upload-attestations
branch
2 times, most recently
from
f01e393
to
9345a6f
Compare
woodruffw
reviewed
Jul 1, 2024
facutuesca
force-pushed
the
upload-attestations
branch
from
58f9c34
to
dd1b1bc
Compare
facutuesca
force-pushed
the
upload-attestations
branch
from
dd1b1bc
to
dc943b5
Compare
woodruffw
reviewed
Jul 10, 2024
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for uploading PEP 740 attestations along with distribution files. Part of #15871.
For now only GHA-signed attestations are supported, but the implementation allows easily adding other publishers by implementing the
OIDCPublisherMixin.publisher_verification_policy()method in the corresponding subclass.Implementation
The core logic is in
legacy.py: we check an upload request to see if it includes any attestations. If it does, we:pypi-attestations.sigstorewith the above verification policy, against the uploaded distribution file.For now we only verify the attestations. Storing them will be implemented in a later PR.
The GHA verification policy (from step 3) is defined in
GitHubPublisherMixin.publisher_verification_policy(), and it checks the certificate in the attestation against the following claims:https://github.com/org/repo/.github/workflows/workflow.yml@....)See here for the definition of each claim.
cc @woodruffw @di